search

vtex-apps / minicart

VTEX Minicart app
10 stars 53 forks source link

feat(accessibility): aria properties added to resolve accessibility a… #331

Closed joaocongio closed 2 months ago

joaocongio commented 1 year ago

What problem is this solving?

Adicionado propriedades ARIA para resolver ajustes apontados pelo Lighthouse. ButtonWithIcon atualmente não aceita a propriedade aria-label. Foi feito um ajuste também no app vtex.styleguide para aceitar essa propriedade. PR Styleguide: https://github.com/vtex/styleguide/pull/1447

How to test it?

Workspace

Executar o teste no Lighthouse ou Pagespeed.

Screenshots or example usage:

Antes da alteração: minicart before

Depois da alteração (o ajuste não foi mais apontado pelo Lighthouse): Minicart After

vtex-io-ci-cd[bot] commented 1 year ago

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

joaocongio commented 1 year ago

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • [x] Patch (backwards-compatible bug fixes)
  • [ ] Minor (backwards-compatible functionality)
  • [ ] Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • [ ] No thanks, I would rather do it manually 😞
joaocongio commented 9 months ago

@gvc tem alguma previsão de deploy para esse ajuste? Obrigado.

joaocore commented 4 months ago

@gvc @filipewl esse ajuste ainda será feito deploy?