vtex-apps / product-quantity

The Product Quantity allows users to a add a chosen amount of the displayed product in their cart.
0 stars 14 forks source link

Feature/numeric stepper props #15

Closed regis-samurai closed 4 years ago

regis-samurai commented 4 years ago

What problem is this solving? This allow to use the unitMultiplier and measurementUnit fields in the product quantity

Most markets need this feature to sell in different units

How should this be manually tested? Link this code version and use it in a store that has different multipliers. I made another pull request that complement this. In the Numeric Stepper component on vtex.styleguide: https://github.com/vtex/styleguide/pull/1173

Screenshots or example usage: Captura de Tela 2020-04-20 às 22 51 07 Captura de Tela 2020-04-20 às 21 03 18

vtex-io-ci-cd[bot] commented 4 years ago

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

vtex-io-docs-bot[bot] commented 4 years ago

Beep boop :robot:

Thank you so much for keeping our documentation up-to-date :heart:

klzns commented 4 years ago

@regis-samurai can you provide a link to a workspace with that feature, please?

Also can you let us modify your pull request: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork

regis-samurai commented 4 years ago

@regis-samurai can you provide a link to a workspace with that feature, please?

Also can you let us modify your pull request: https://help.github.com/en/github/collaborating- with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork

Actually, this checkbox already checked: Captura de Tela 2020-04-24 às 10 36 58

And the workspace running this feature is on the link: https://multiplier--cbyio.myvtex.com/

klzns commented 4 years ago

I updated the PR to show the measurementUnit if it's different from the default un

So there's no need for the prop anymore

https://breno--storecomponents.myvtex.com/orange-juice/p

regis-samurai commented 4 years ago

I updated the PR to show the measurementUnit if it's different from the default un

So there's no need for the prop anymore

https://breno--storecomponents.myvtex.com/orange-juice/p

@klzns Perfect!

vtex-io-ci-cd[bot] commented 4 years ago

Your PR has been merged! App is being published. :rocket: Version 1.3.2 → 1.4.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.product-quantity@1.4.0

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. :book:

klzns commented 4 years ago

@allcontributors add @regis-samurai for code

allcontributors[bot] commented 4 years ago

@klzns

I've put up a pull request to add @regis-samurai! :tada: