fix types and protect against undefined selectedItem

vtex-apps / product-quantity

The Product Quantity allows users to a add a chosen amount of the displayed product in their cart.

0 stars 14 forks source link

fix types and protect against undefined selectedItem #18

Closed jgfidelis closed 4 years ago

jgfidelis commented 4 years ago

What problem is this solving?

const { unitMultiplier, measurementUnit } = selectedItem

This line is breaking stuff in ssr because selectedItem may be undefined

How should this be manually tested?

Screenshots or example usage:

vtex-io-ci-cd[bot] commented 4 years ago

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

[x] Patch
[ ] Minor
[ ] Major

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

[ ] No thanks, I would rather do it manually 😞

vtex-io-docs-bot[bot] commented 4 years ago

Beep boop :robot:

I noticed you didn't make any changes at the docs/ folder

[x] There's nothing new to document :thinking:
[ ] I'll do it later :disappointed:

In order to keep track, I'll create an issue if you decide now is not a good time

[ ] I just updated :tada::tada:

vtex-io-ci-cd[bot] commented 4 years ago

Your PR has been merged! App is being published. :rocket: Version 1.4.0 → 1.4.1

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.product-quantity@1.4.1

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. :book: