Fixing stepper's minimum value behavior

vtex-apps / product-quantity

The Product Quantity allows users to a add a chosen amount of the displayed product in their cart.

0 stars 14 forks source link

Fixing stepper's minimum value behavior #29

Closed icazevedo closed 3 years ago

icazevedo commented 3 years ago

What problem is this solving?

This PR fixes the minimum value used for products with unitMultiplier different from 1. Previously, this behavior was guaranted by the stepper itself (from the styleguide), but in an erroneous way. Dealing with that there could create issues.

How to test it?

Workspace

Screenshots or example usage:

Related to / Depends on

Related to styleguide#1366

How does this PR make you feel? :link:

"stepper"

vtex-io-ci-cd[bot] commented 3 years ago

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

[x] Patch (backwards-compatible bug fixes)
[ ] Minor (backwards-compatible functionality)
[ ] Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

[ ] No thanks, I would rather do it manually 😞

vtex-io-docs-bot[bot] commented 3 years ago

Beep boop :robot:

I noticed you didn't make any changes at the docs/ folder

[x] There's nothing new to document :thinking:
[ ] I'll do it later :disappointed:

In order to keep track, I'll create an issue if you decide now is not a good time

[ ] I just updated :tada::tada:

icazevedo commented 3 years ago

It's no longer needed since the fix on the stepper has changed.