Fix product impression on legacy components

vtex-apps / product-summary

VTEX Product Summary app

11 stars 51 forks source link

Fix product impression on legacy components #252

Closed iaronaraujo closed 4 years ago

iaronaraujo commented 4 years ago

What is the purpose of this pull request?

The legacy components weren't sending impression events. This PR fixes this

How should this be manually tested?

Workspace Go on console, type pixelManagerEvents and check that the productImpression event is being sent.

vtex-io-ci-cd[bot] commented 4 years ago

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

[x] Patch
[ ] Minor
[ ] Major

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

[ ] No thanks, I would rather do it manually 😞

vtex-io-docs-bot[bot] commented 4 years ago

Beep boop :robot:

I noticed you didn't make any changes at the docs/ folder

[x] There's nothing new to document :thinking:
[ ] I'll do it later :disappointed:

In order to keep track, I'll create an issue if you decide now is not a good time

[ ] I just updated :tada::tada:

vtex-io-ci-cd[bot] commented 4 years ago

Your PR has been merged! App is being published. :rocket: Version 2.53.1 → 2.53.2

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.product-summary@2.53.2

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. :book: