vtex-apps / product-summary

VTEX Product Summary app
11 stars 51 forks source link

Fix collection variable of wrong type being used to perform Product Query #256

Closed victorhmp closed 4 years ago

victorhmp commented 4 years ago

What is the purpose of this pull request?

Fix an issue where the Product query performed by ProductSummaryList would result in an Internal Server Error.

Screen Shot 2020-04-24 at 09 56 14

What problem is this solving?

The collection prop received by the ProductSummaryList component was receiving an invalid value from the CMS due to its type being wrong in the component's schema.

While collection should be string value, it was defined in the component's schema as a number.

How should this be manually tested?

Go to this Workspace and set an existing collection value in ProductList's content configuration.

Types of changes

vtex-io-ci-cd[bot] commented 4 years ago

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

vtex-io-docs-bot[bot] commented 4 years ago

Beep boop :robot:

I noticed you didn't make any changes at the docs/ folder

In order to keep track, I'll create an issue if you decide now is not a good time

vtex-io-ci-cd[bot] commented 4 years ago

Your PR has been merged! App is being published. :rocket: Version 2.53.2 → 2.53.3

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.product-summary@2.53.3

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. :book: