vtex-apps / product-summary

VTEX Product Summary app
11 stars 51 forks source link

Fix ProductImage crashing when there is no image to render #259

Closed Klynger closed 4 years ago

Klynger commented 4 years ago

What is the purpose of this pull request?

As the title says

How should this be manually tested?

  1. workspace
  2. To test this I removed all images in code to reproduce the use case, but if you want to see a product with an image, just open the quick view of the second item and it will magically display one

Screenshots or example usage

image

Types of changes

vtex-io-ci-cd[bot] commented 4 years ago

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

vtex-io-docs-bot[bot] commented 4 years ago

Beep boop :robot:

I noticed you didn't make any changes at the docs/ folder

In order to keep track, I'll create an issue if you decide now is not a good time

vtex-io-ci-cd[bot] commented 4 years ago

Your PR has been merged! App is being published. :rocket: Version 2.54.0 → 2.54.1

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.product-summary@2.54.1

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. :book: