Feature/gtm major compatibility

vtex-apps / product-summary

VTEX Product Summary app

11 stars 52 forks source link

Feature/gtm major compatibility #308

Closed icazevedo closed 3 years ago

icazevedo commented 3 years ago

What problem is this solving?

This PR makes the Product Summary compatible with the new GTM major and fixes two issues: the seller selection wasn't considering default sellers as the rest of the apps and actionOnClick was not passed to ProductSummary when used as slots.

How to test it?

Workspace

Related to / Depends on

Depends on https://github.com/vtex-apps/product-summary-context/pull/18

How does this PR make you feel? :link:

vtex-io-ci-cd[bot] commented 3 years ago

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

[ ] Patch (backwards-compatible bug fixes)
[x] Minor (backwards-compatible functionality)
[ ] Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

[ ] No thanks, I would rather do it manually 😞

vtex-io-docs-bot[bot] commented 3 years ago

Beep boop :robot:

I noticed you didn't make any changes at the docs/ folder

[x] There's nothing new to document :thinking:
[ ] I'll do it later :disappointed:

In order to keep track, I'll create an issue if you decide now is not a good time

[ ] I just updated :tada::tada:

vtex-io-ci-cd[bot] commented 3 years ago

Your PR has been merged! App is being published. :rocket: Version 2.72.0 → 2.73.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.product-summary@2.73.0

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. :book: