search

vtex-apps / product-summary

VTEX Product Summary app
11 stars 51 forks source link

Changing listName to be sent to pdp via params #318

Closed icazevedo closed 3 years ago

icazevedo commented 3 years ago

What problem is this solving?

Product Summary now sends the listName to the PDP via runtime params. This PR adds this behavior to legacy Product Summaries and also re-enables de default true behavior of the trackListName prop. listName is now invisible to the user and is more appropriate for this use case.

How to test it?

Click any shelf or search result. It should take you to the product page. Type dataLayer into your console, and check for the last productDetail event. It should have the name of the list you clicked somewhere there. The default listName for shelves is List of products.

Workspace

Describe alternatives you've considered, if any.

I tried putting it on the URL, it broke some marketing campaigns and clients complained about it.

Related to / Depends on

Depends on https://github.com/vtex-apps/product-summary-context/pull/19

How does this PR make you feel? :link:

vtex-io-ci-cd[bot] commented 3 years ago

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

vtex-io-docs-bot[bot] commented 3 years ago

Beep boop :robot:

Thank you so much for keeping our documentation up-to-date :heart:

vtex-io-ci-cd[bot] commented 3 years ago

Your PR has been merged! App is being published. :rocket: Version 2.73.2 → 2.74.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.product-summary@2.74.0

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. :book: