Set a specific SKU in the product context

vtex-apps / product-summary

VTEX Product Summary app

11 stars 51 forks source link

Set a specific SKU in the product context #328

Closed Git-the-Sanz closed 3 years ago

Git-the-Sanz commented 3 years ago

What problem is this solving?

There was no way of specifying which SKU should be the initial selection in product summaries (Both sliders and galleries). We are now letting the client specify a logic to then use it for the product-context, which in turn will provide the selected item property to it's childrens.

How to test it?

CHEAPEST (You will see the cheapest products selected)

SPECIFICATION (Look for MOTO G7 PLUS, you will see that the SKU No. 35 is selected, thanks to it's product property called DefaultSKU)

Screenshots or example usage:

For i.e: By passing "SPECIFICATION" the SKU No. 35 was automatically selected in the Gallery

item

Describe alternatives you've considered, if any.

We know that the Admin SKU Position exists, but as of today, this is not working (Confirmed by Catalog team)

Related to / Depends on

Search result PR

How does this PR make you feel?

vtex-io-ci-cd[bot] commented 3 years ago

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

[ ] Patch (backwards-compatible bug fixes)
[x] Minor (backwards-compatible functionality)
[ ] Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

[ ] No thanks, I would rather do it manually 😞

vtex-io-docs-bot[bot] commented 3 years ago

Beep boop :robot:

Thank you so much for keeping our documentation up-to-date :heart:

Git-the-Sanz commented 3 years ago

@icazevedo Thank you for your input.

I typed everything; except the property normalizedProduct.sku (I could't manage to do it, the object is particularly weird; and it's used and mutated-around inside product-summary)
I renamed some functions. They now reflect better what they do.
I refactored the reduce function. Since the beginning I felt that this approach was barely performant. I now only run the price lookup function once for each SKU, and then just return the best one using the index from max/min.
Regarding why I'm using .some() I only care for the potential Items with stock. That's the difference with the other applications.
Regarding your comment about the Specification. I implemented that one. We first check if the property exists, if it does, we will attempt to retrieve it; if the property is incorrectly valued, we instead attempt to use the switch to find a suitable one.

Thank you again! We really value your feedback

vtex-io-ci-cd[bot] commented 3 years ago

Your PR has been merged! App is being published. :rocket: Version 2.75.0 → 2.76.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.product-summary@2.76.0

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. :book: