search

vtex-apps / product-summary

VTEX Product Summary app
11 stars 52 forks source link

added lazyload prop to images #335

Closed zagamendes closed 2 years ago

zagamendes commented 3 years ago

What problem is this solving?

Saving a lot of data of being downloaded without needs

My client would like to add the hover functionality on shelves of category and collection, however the page is load with 20 shelves, and every shelf has a picture, when hover is acitved, the number of images go from 20 to 40, this decreases our performance score. With this feature, the page will only load 20 pictures and whenever the user hovers through a shelf, then it will download the next image and show it

How to test it?

Just browse through the shelves with the network pannel opened and you will see

Workspace

vtex-io-ci-cd[bot] commented 3 years ago

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

vtex-io-docs-bot[bot] commented 3 years ago

Beep boop :robot:

I noticed you didn't make any changes at the docs/ folder

In order to keep track, I'll create an issue if you decide now is not a good time

zagamendes commented 3 years ago

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • [x] Patch (backwards-compatible bug fixes)
  • [ ] Minor (backwards-compatible functionality)
  • [ ] Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • [ ] No thanks, I would rather do it manually 😞
zagamendes commented 3 years ago

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • [ ] There's nothing new to document 🤔
  • [ ] I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • [x] I just updated 🎉🎉