vtex-apps / product-summary

VTEX Product Summary app
11 stars 52 forks source link

Add v param to images to permit caching it on CDN #339

Closed vitorflg closed 2 years ago

vitorflg commented 2 years ago

What problem is this solving?

The problem is explained in this thread.

TL;DR: In the @gaoneto words: "Basically we want to add a change that we can cache assets “forever” on the CDN. If we keep things like this (https://dzarm.vtexassets.com/arquivos/pinterest-footer-icon.jpg), for instance, we will not be able to cache indefinitely. If we use as the way Portal does (https://rihappy.vteximg.com.br/arquivos/ids/1407630/banner-full-rihappy-desk-dia-quanto-mais-brincadeira-melhor.png?v=637581831630730000, the ?v parameter changes whenever the asset changes) we are able to cache indefinitely on the CDN."

How to test it?

You can test it in the: *All images should have a ?v param

Workspace

Screenshots or example usage:

X

Describe alternatives you've considered, if any.

X

Related to / Depends on

X

vtex-io-ci-cd[bot] commented 2 years ago

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

vtex-io-docs-bot[bot] commented 2 years ago

Beep boop :robot:

I noticed you didn't make any changes at the docs/ folder

In order to keep track, I'll create an issue if you decide now is not a good time

vtex-io-ci-cd[bot] commented 2 years ago

Your PR has been merged! App is being published. :rocket: Version 2.77.0 → 2.77.1

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.product-summary@2.77.1

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. :book: