vtex-apps / product-summary

VTEX Product Summary app
11 stars 52 forks source link

new component: Product category link. it links into the product's cat… #344

Closed kaibrockelt closed 1 year ago

kaibrockelt commented 2 years ago

…egory

What problem is this solving?

IBK Bike (new integration) requested to have the category link available in product shelfs. Instead of building something custom, i thought this is generally handy to bump up the user navigation success and making them find what they are looking for.

This allows users to jump into category pages from wherever they might find a product summary. This is including Homepage, search results, category or brand pages etc.

How to test it?

Easy! Go to my workspace and find the link to the category in the product summary.

kaibrockelt appliancetheme

Screenshots or example usage:

"product-summary.shelf": {
    "children": [
      "stack-layout#prodsum",
      "product-summary-name",
+      "product-summary-category-link",
      "flex-layout.col#productRating",
      "product-summary-space",
      "product-list-price#summary",
      "flex-layout.row#selling-price-savings",
      "product-installments#summary",
      "add-to-cart-button"
    ]
  },

Renders into: CategoryLink

Describe alternatives you've considered, if any.

Building this with a store link failed on dynamically adding the category's name.

Related to / Depends on

nothing. its a newly exposed block with no props to configure except for the custom css class.

How does this PR make you feel? :link:

vtex-io-ci-cd[bot] commented 2 years ago

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

vtex-io-docs-bot[bot] commented 2 years ago

Beep boop :robot:

Thank you so much for keeping our documentation up-to-date :heart:

kaibrockelt commented 2 years ago

In only 15 edits i managed to kill all blank space issues that lint found over and over again.

now it's failing for issues on code that i never touched, somewhere in the legacy folder. I am lost. MergeRequests

kaibrockelt commented 2 years ago

The remaining lint errors all point to mock components which i never ever touched.

/github/workspace/react/__mocks__/vtex.store-components/ProductPrice.js`
 7:17  error  Parsing error: Unexpected token =`

/github/workspace/react/__mocks__/vtex.store-components/index.js
  8:17  error  Parsing error: Unexpected token =

/github/workspace/react/components/ProductSummaryAttachmentList/AttachmentList.js
  18:32  error  Parsing error: Unexpected token .

/github/workspace/react/legacy/components/ProductQuantityStepper.js
  28:20  error  Parsing error: Unexpected token =

/github/workspace/react/legacy/index.js
  30:20  error  Parsing error: Unexpected token =
kaibrockelt commented 1 year ago

After 1 year and 2 days i believe this wont get merged. good night.