search

vtex-apps / product-summary

VTEX Product Summary app
11 stars 51 forks source link

Use h3 by default instead of h1 #359

Closed polishq closed 2 years ago

polishq commented 2 years ago

What problem is this solving?

Although Google has said that technically there is nothing wrong with having multiple H1 tags on a page, it is still W3C best practice to limit each page to one H1 tag. Having a single H1 tag helps make the page more semantic and accessible (for instance with users of screen readers). This PR changes the default tag for the ProductSummaryName to h3 instead of h1 (the thought process being that the title of the PLP would be an h1, then there may be a content area with an h2, then each product's name becomes an h3).

How to test it?

Linked here: https://h3test--esika.myvtex.com/maquillaje/c

vtex-io-ci-cd[bot] commented 2 years ago

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

vtex-io-ci-cd[bot] commented 2 years ago

Your PR has been merged! App is being published. :rocket: Version 2.80.0 → 2.80.1

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.product-summary@2.80.1

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. :book: