vtex-apps / product-summary

VTEX Product Summary app
11 stars 51 forks source link

Add `rootPath` handling in useSession #375

Closed brunorodmoreira closed 1 year ago

brunorodmoreira commented 1 year ago

What problem is this solving?

Sessions APIs request didn't consider the rootPath when building the URL, then the requests return an error 404.

How to test it?

It should be tested in public domains because there's no rootPath in "myvtex", it's a CDN routing thing. I created two workspaces with Store Theme to ease the visualization.

With my improvement Without my improvement

The page should be scrolled to the first shelf because there are other Sessions requests from another component.

Screenshots or example usage:

Describe alternatives you've considered, if any.

Related to / Depends on

How does this PR make you feel? :link:

![](put .gif link here - can be found under "advanced" on giphy)

vtex-io-ci-cd[bot] commented 1 year ago

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

filipewl commented 1 year ago

About the checks:

CleanShot 2023-06-22 at 14 19 30


With all that said, I'm going ahead to merge and deploy this.

vtex-io-ci-cd[bot] commented 1 year ago

Your PR has been merged! App is being published. :rocket: Version 2.83.1 → 2.83.2

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.product-summary@2.83.2

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. :book: