feat: Added a prop to set the max description dynamically

vtex-apps / product-summary

VTEX Product Summary app

11 stars 51 forks source link

feat: Added a prop to set the max description dynamically #380

Closed arturmagalhaesjr closed 1 year ago

arturmagalhaesjr commented 1 year ago

What problem is this solving?

It has been added a way to set the max description which is hardcoded by a constant (120).

This way is possible to set a new property on the Product Description Component which makes it possible to set it on the theme blocks.

How to test it?

https://artur2--beautycounterqa.myvtex.com/

Screenshots or example usage:

vtex-io-ci-cd[bot] commented 1 year ago

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

[ ] Patch (backwards-compatible bug fixes)
[x] Minor (backwards-compatible functionality)
[ ] Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

[ ] No thanks, I would rather do it manually 😞

vtex-io-docs-bot[bot] commented 1 year ago

Beep boop :robot:

I noticed you didn't make any changes at the docs/ folder

[ ] There's nothing new to document :thinking:
[x] I'll do it later :disappointed:

In order to keep track, I'll create an issue if you decide now is not a good time

[ ] I just updated :tada::tada:

vtex-io-ci-cd[bot] commented 1 year ago

Your PR has been merged! App is being published. :rocket: Version 2.83.5 → 2.84.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.product-summary@2.84.0

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. :book: