vtex-apps / product-summary

VTEX Product Summary app
11 stars 51 forks source link

sponsoredBadgeLabel added as a required prop #389

Open bruno-monteiro1 opened 11 months ago

bruno-monteiro1 commented 11 months ago

Describe the bug The prop sponsoredBadgeLabel was added to the ProductSummaryName component, but not as optional, even though the component to which it passes on receives it as optional. This change got release as a minor (2.87.0), but breaks TS build on projects that depend on this.

To Reproduce No need to reproduce, just check the sponsoredBadgeLabel typing on the ProductSummaryName component and see that it is required. Than, check that it is optional in the only component it gets passed on.

Expected behavior The expected behaviour is that the prop is set as optional, not only because it is optional in the component it gets passed on, but also because it did not exist in previous versions of the same major.