[REVIEWS-121] stars percentage mismatch

aurorahey commented 1 year ago

What problem is this solving?

There were two issues that cause the stars' percentage mismatch problem: 1) Reviews are not supposed to have 0 stars but admin can setup 0 stars as default, so we got many 0 stars reviews.

This PR consider all 0 stars review counted as 1 stars review. And remove the option of 0 stars, so we won't get any more 0 stars reviews.

2) Previously, the stars count happen at the frontend, and it counts the review data at the current paginated page but all the reviews.

This PR added the count stars logic inside the averageRatingByProductId query. so that the counts could be generated while calculating the average. The stars count has been added as the return values of the query.

How to test it?

Workspace GraphiQL

vtex-io-ci-cd[bot] commented 1 year ago

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

[x] Patch (backwards-compatible bug fixes)
[ ] Minor (backwards-compatible functionality)
[ ] Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

[ ] No thanks, I would rather do it manually 😞

sonarcloud[bot] commented 1 year ago

[vtex-apps_reviews-and-ratings-ts] Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
11.8% Duplication

sonarcloud[bot] commented 1 year ago

[vtex-apps_reviews-and-ratings-dotnet] Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

0.0% Coverage
0.0% Duplication

github-actions[bot] commented 1 year ago

Cypress Runner

Execution report

 [✓] Execution time
  -  initWorkspace................. 3.691 seconds
  -  installApps................... 0 seconds
  -  uninstallApps................. 0 seconds
  -  linkApp....................... 50.06 seconds
  -  strategy...................... 520.478 seconds
  -  teardown...................... 13.153 seconds
  -  total......................... 590.375 seconds

 [✓] Successful specs
  -  2.1.1-anonymous_user.spec.js
  -  2.1.2-signed_in_user.spec.js
  -  2.1.3-verify_review_with_signed_user.spec.js
  -  2.2.1-ordering_the_product.spec.js
  -  2.2.2-anonymous_user.spec.js
  -  2.2.3-signed_in_user.spec.js
  -  2.2.4-verify_review_with_signed_user.spec.js
  -  2.3.1-anonymous_user.spec.js
  -  2.3.2-signed_in_user.spec.js
  -  2.4.1-anonymous_user.spec.js
  -  2.4.2-signed_in_user.spec.js
  -  2.5-rest_apis.spec.js
  -  2.6-graphql.spec.js
  -  2.7.1-disable_display_settings_&_verify_with_anonymous_user.spec.js
  -  2.7.2-enable_display_settings_&_verify_with_anonymous_user.spec.js
  -  2.7.3-enable_display_settings_&_verify_with_signed_in_user.spec.js
  -  2.7.4-disable_display_settings_&_verify_with_signed_in_user.spec.js
  -  wipe.spec.js

Cypress Dashboard

 [✓] https://dashboard.cypress.io/projects/964exx/runs/215

Success

 [✓] The test ran successfully, well done!

vtex-io-ci-cd[bot] commented 1 year ago

Your PR has been merged! App is being published. :rocket: Version 3.11.1 → 3.11.2

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.reviews-and-ratings@3.11.2

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. :book:

vtex-apps / reviews-and-ratings