vtex-apps / reviews-and-ratings

5 stars 20 forks source link

[REVIEWS-134] fix review state #231

Closed aurorahey closed 1 year ago

aurorahey commented 1 year ago

What problem is this solving?

the previous fix about loading star causing infinite request, this PR fix both the infinite request and the PDP loading star problem. Also improved GetAverageRatingByProductId query.

How to test it?

Use Incognito mode to open link https://esika.tiendabelcorp.cl/vibranza-perfume-de-mujer-45-ml/p?workspace=aurora111 you should see all the stars showing

open any review page to see the requests

vtex-io-ci-cd[bot] commented 1 year ago

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

vtex-io-docs-bot[bot] commented 1 year ago

Beep boop :robot:

I noticed you didn't make any changes at the docs/ folder

In order to keep track, I'll create an issue if you decide now is not a good time

github-actions[bot] commented 1 year ago
Messages
:book: :heart: Thanks!
:book: :tada: PR additions = `40`, PR deletions = `35`

Generated by :no_entry_sign: dangerJS against d73d0031f19c3580936ee9d3734eadfd9272f2e1

sonarcloud[bot] commented 1 year ago

[vtex-apps_reviews-and-ratings-ts] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

sonarcloud[bot] commented 1 year ago

[vtex-apps_reviews-and-ratings-dotnet] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

github-actions[bot] commented 1 year ago

Cy-Runner

 [✓] Execution time
  -  initWorkspace................. 00:00:03
  -  installApps................... 00:00:00
  -  uninstallApps................. 00:00:00
  -  linkApp....................... 00:00:30
  -  strategy...................... 00:08:22
  -  teardown...................... 00:00:13
  -  total......................... 00:09:12

Cypress Dashboard

 [✓] https://cloud.cypress.io/projects/964exx/runs/312

Success

 [✓] The test ran successfully, well done!
vtex-io-ci-cd[bot] commented 1 year ago

Your PR has been merged! App is being published. :rocket: Version 3.12.3 → 3.12.4

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.reviews-and-ratings@3.12.4

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. :book: