Removes store-graphql dependency

danzanzini commented 1 year ago

What problem is this solving?

The store-graphql orders query uses a deprecated API, and we need to remove all usage of it to shut down the endpoint. We found out that the reviews-and-ratings use this query to fetch the user orders in the ReviewForm component.

The goal of this fetch was to set the verifiedPurchaser state on the form, but this attribute is not used anymore. So we simply removed the call to the API and all related code to this attribute.

How to test it?

Log in and add a review to any item. The process should work with no problem Workspace

vtex-io-ci-cd[bot] commented 1 year ago

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

[x] Patch (backwards-compatible bug fixes)
[ ] Minor (backwards-compatible functionality)
[ ] Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

[ ] No thanks, I would rather do it manually 😞

vtex-io-docs-bot[bot] commented 1 year ago

Beep boop :robot:

I noticed you didn't make any changes at the docs/ folder

[x] There's nothing new to document :thinking:
[ ] I'll do it later :disappointed:

In order to keep track, I'll create an issue if you decide now is not a good time

[ ] I just updated :tada::tada:

github-actions[bot] commented 1 year ago

	Messages
:book:	:heart: Thanks!
:book:	:tada: PR additions = `7`, PR deletions = `72`

Generated by :no_entry_sign: dangerJS against acc17ffbe2a455fcda7cf048a9d84386f815d0ec

sonarcloud[bot] commented 1 year ago

[vtex-apps_reviews-and-ratings-ts] Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

sonarcloud[bot] commented 1 year ago

[vtex-apps_reviews-and-ratings-dotnet] Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

github-actions[bot] commented 1 year ago

Cy-Runner

 [✓] Execution time
  -  initWorkspace................. 00:00:03
  -  installApps................... 00:00:00
  -  uninstallApps................. 00:00:00
  -  linkApp....................... 00:00:30
  -  strategy...................... 00:09:02
  -  teardown...................... 00:00:12
  -  total......................... 00:09:51

Cypress Dashboard

 [✓] https://cloud.cypress.io/projects/964exx/runs/326

Success

 [✓] The test ran successfully, well done!

polishq commented 1 year ago

@danzanzini Can you elaborate on "this attribute is not used anymore"? To my knowledge it's still in use.

danzanzini commented 1 year ago

Hey @polishq. https://github.com/vtex-apps/reviews-and-ratings/commit/e3613081d7a945ee0ed8b30048697926bb709dbd removed the usage of the verifiedPurchaser state attribute when creating the review

vtex-io-ci-cd[bot] commented 1 year ago

Your PR has been merged! App is being published. :rocket: Version 3.12.4 → 3.12.5

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.reviews-and-ratings@3.12.5

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. :book:

vtex-apps / reviews-and-ratings