vtex-apps / reviews-and-ratings

5 stars 20 forks source link

Added Translation for Show more/ Show less text #243

Closed mihaidanieldumitru closed 1 year ago

mihaidanieldumitru commented 1 year ago

What problem is this solving?

In this PR i've added translations & handle for Show more/Show less text that appear when a review has more than 3 lines of text and is truncated.

How to test it?

Workspace

Screenshots or example usage:

image image image

vtex-io-ci-cd[bot] commented 1 year ago

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

vtex-io-docs-bot[bot] commented 1 year ago

Beep boop :robot:

Thank you so much for keeping our documentation up-to-date :heart:

github-actions[bot] commented 1 year ago
Warnings
:warning: Looks like this PR is too large [:bulb: smaller PRs are easy to review and approve]
Messages
:book: :heart: Thanks!
:book: :tada: PR additions = `83`, PR deletions = `30`

Generated by :no_entry_sign: dangerJS against 4ba5f5c74fd6be7106b6acf2d8b182795869680e

sonarcloud[bot] commented 1 year ago

[vtex-apps_reviews-and-ratings-ts] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

mihainutiu-vtex commented 1 year ago

Hi @mihaidanieldumitru I published a beta version with your PR so you can install on the client account vtex.reviews-and-ratings@3.12.6-beta.0

github-actions[bot] commented 1 year ago

Cy-Runner

 [✓] Execution time
  -  initWorkspace................. 00:00:03
  -  installApps................... 00:00:00
  -  uninstallApps................. 00:00:00
  -  linkApp....................... 00:00:40
  -  strategy...................... 00:09:15
  -  teardown...................... 00:00:13
  -  total......................... 00:10:15

Cypress Dashboard

 [✓] https://cloud.cypress.io/projects/964exx/runs/353

Success

 [✓] The test ran successfully, well done!