Wildcard locales as fallback

vtex-apps / reviews-and-ratings

5 stars 20 forks source link

Wildcard locales as fallback #254

Closed jumc closed 9 months ago

jumc commented 9 months ago

What problem is this solving?

Wildcard queries are expensive to process at Masterdata. Since locales are finite and defined at ISO-639-1 and country codes too (for ISO-3166-1) we are able to use locale values statically and change the wildcard query to OR. We'll keep the wildcard as fallback.

vtex-io-ci-cd[bot] commented 9 months ago

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

[ ] Patch (backwards-compatible bug fixes)
[x] Minor (backwards-compatible functionality)
[ ] Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

[ ] No thanks, I would rather do it manually 😞

vtex-io-docs-bot[bot] commented 9 months ago

Beep boop :robot:

I noticed you didn't make any changes at the docs/ folder

[x] There's nothing new to document :thinking:
[ ] I'll do it later :disappointed:

In order to keep track, I'll create an issue if you decide now is not a good time

[ ] I just updated :tada::tada:

github-actions[bot] commented 9 months ago

	Messages
:book:	:heart: Thanks!
:book:	:tada: PR additions = `159`, PR deletions = `7`

Generated by :no_entry_sign: dangerJS against 99da173e9a391c2687c2f1f0727ab30b8ab10cdb

vtex-io-ci-cd[bot] commented 9 months ago

Your PR has been merged! App is being published. :rocket: Version 3.13.3 → 3.14.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.reviews-and-ratings@3.14.0

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. :book: