vtex-apps / store-footer

VTEX Footer app for IO Stores
5 stars 7 forks source link

Remove lazy svg #102

Closed thiagomurakami closed 4 years ago

thiagomurakami commented 4 years ago

What is the purpose of this pull request?

Remove lazy load from some components. Also removed legacy HoC components (injectIntl, withRuntimeContext) whenever possible.

What problem is this solving?

This optimisation is kind of useless since the icons always appear and result in more requests:

Screen Shot 2020-03-02 at 20 02 16

Screenshots or example usage

Types of changes

vtex-io-ci-cd[bot] commented 4 years ago

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

vtex-io-docs-bot[bot] commented 4 years ago

Beep boop :robot:

I noticed you didn't make any changes at the docs/ folder

In order to keep track, I'll create an issue if you decide now is not a good time

thiagomurakami commented 4 years ago

Just to clarify, this PR removes only the additional 4.min.js, 8.min.js, etc. It doesn't remove the SVG request itself.

kaisermann commented 4 years ago

@thiagomurakami You're only missing some mocks (useRuntime) for the tests to pass

vtex-io-ci-cd[bot] commented 4 years ago

Your PR has been merged! App is being published. :rocket: Version 2.19.1 → 2.19.2

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.store-footer@2.19.2

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. :book: