vtex-apps / store-footer

VTEX Footer app for IO Stores
5 stars 7 forks source link

Fix/partial hydration #106

Closed lbebber closed 4 years ago

lbebber commented 4 years ago

What is the purpose of this pull request?

Fixes bug where __fold__.experimentalLazyAssets combined with the regular __fold__ wouldn't render the footer properly.

Partially pre-existing, exacerbated by https://github.com/vtex-apps/render-runtime/pull/505

To test, go to https://www.als.com/?workspace=lbebberprod1 and scroll down. The footer should be visible in normal circumstances.

What problem is this solving?

How should this be manually tested?

Screenshots or example usage

Types of changes

vtex-io-ci-cd[bot] commented 4 years ago

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

vtex-io-docs-bot[bot] commented 4 years ago

Beep boop :robot:

I noticed you didn't make any changes at the docs/ folder

In order to keep track, I'll create an issue if you decide now is not a good time

lbebber commented 4 years ago

Fixed by https://github.com/vtex-apps/render-runtime/pull/505