handle error on itemsWithSimulation

vtex-apps / store-graphql

GraphQL schema and resolvers for the VTEX Commerce Stores API

78 stars 45 forks source link

handle error on itemsWithSimulation #573

Closed hiagolcm closed 3 years ago

hiagolcm commented 3 years ago

What problem is this solving?

This PR fixes two problems:

When the simulation API returns an error the store-graphql request get stuck until it hits the timeout. This is happening because the error is throw inside a promise.
When there is more than one seller and one of them returns an error, the itemsWithSimulation query is not returning any of them.

How to test it?

Workspace

vtex-io-ci-cd[bot] commented 3 years ago

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

[x] Patch (backwards-compatible bug fixes)
[ ] Minor (backwards-compatible functionality)
[ ] Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

[ ] No thanks, I would rather do it manually 😞

vtex-io-docs-bot[bot] commented 3 years ago

Beep boop :robot:

I noticed you didn't make any changes at the docs/ folder

[x] There's nothing new to document :thinking:
[ ] I'll do it later :disappointed:

In order to keep track, I'll create an issue if you decide now is not a good time

[ ] I just updated :tada::tada:

vtex-io-ci-cd[bot] commented 3 years ago

Your PR has been merged! App is being published. :rocket: Version 2.146.1 → 2.146.2

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.store-graphql@2.146.2

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. :book: