vtex-apps / store-graphql

GraphQL schema and resolvers for the VTEX Commerce Stores API
78 stars 45 forks source link

Stop sending pwd on querystring #577

Closed rnbez closed 3 years ago

rnbez commented 3 years ago

What problem is this solving?

This PR updates some of the authentication requests to stop sending email and password on the querystring and pass it on the body instead.

How to test it?

Go to https://idcs765--storecomponents.myvtex.com/_v/private/vtex.store-graphql@2.147.1/graphiql/v1 and try the mutations:

Here are some examples you can copy and paste (changing the email):

mutation {
  sendEmailVerification(email: "{email}")
}

mutation {
  recoveryPassword(
    email: "{email}", 
    newPassword: "{pass}", 
    code: "{code}"
  )
}

mutation {
  redefinePassword(
    email: "{email}", 
    currentPassword: "{pass}", 
    newPassword: "{pass}"
  )
}
vtex-io-ci-cd[bot] commented 3 years ago

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

vtex-io-docs-bot[bot] commented 3 years ago

Beep boop :robot:

I noticed you didn't make any changes at the docs/ folder

In order to keep track, I'll create an issue if you decide now is not a good time

vtex-io-ci-cd[bot] commented 3 years ago

Your PR has been merged! App is being published. :rocket: Version 2.147.3-beta.0 → 2.147.3

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.store-graphql@2.147.3

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. :book: