vtex-apps / store-graphql

GraphQL schema and resolvers for the VTEX Commerce Stores API
78 stars 45 forks source link

Feat/orderform same site cookie #640

Closed Mecrano closed 1 year ago

Mecrano commented 1 year ago

What problem is this solving?

Many stores need to be inside an iframe, this is only possible if the orderform cookie (checkout.vtex.com) has the SameSite='None' property set, an option was created in the app configuration to enable this feature, by default it is set to false to keep the stores that do not need this feature unaffected.

How to test it?

  1. Link the application
  2. Set the SameSite='None' flag to true through the administrator.
  3. See how the cookie property changes.

Screenshots or example usage:

image image

vtex-io-ci-cd[bot] commented 1 year ago

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

vtex-io-docs-bot[bot] commented 1 year ago

Beep boop :robot:

I noticed you didn't make any changes at the docs/ folder

In order to keep track, I'll create an issue if you decide now is not a good time

danzanzini commented 1 year ago

Hey @Mecrano. Can you provide a linked worskpace for testing purposes? I also recommend the @vtex-apps/checkout-team to take a look at this PR

danzanzini commented 1 year ago

@Mecrano Our security team recommended not moving on with this change due to it being a potential security risk. I'm closing this PR.