vtex-apps / store-graphql

GraphQL schema and resolvers for the VTEX Commerce Stores API
78 stars 45 forks source link

Fix: telesales for PII accounts #662

Closed beatrizmaselli closed 5 months ago

beatrizmaselli commented 5 months ago

What problem is this solving?

Telesales feature not working for PII accounts.

This endpoint is not public for PII accounts:

curl --location 'https://dunnesstoresqa.vtexcommercestable.com.br/api/checkout/pub/orderForm/ef55388eedd04d6da04e42dd05251570' \
--header 'Accept: application/json' \
--header 'Content-Type: application/json' \
--header 'Cookie: CheckoutOrderFormOwnership=; checkout.vtex.com=__ofid=ef55388eedd04d6da04e42dd05251570' \
--data '{
    "expectedOrderFormSections": [
        "items"
    ]
}'

I need to double check with the checkout team but the error returned is:

{
    "fields": {},
    "error": {
        "code": "001",
        "message": "The key \"schema\" was not found in the response",
        "exception": null
    },
    "operationId": "917e31e9-a252-4dc8-82cb-c3611fd16706"
}

How to test it?

  1. Enter a PII account
  2. Add the telesales toolbar
  3. Add a telesales role to your user
  4. Call the store-graphql for impersonification
  5. With the previous version the return is 500 and with the current version is 200

Workspace

Only this PR do not solve the telesales problem since the profile was not completed by the session. It was needed to develop an extra App in order to do so.

Related to / Depends on

Only this PR do not solve the telesales problem since the profile was not completed by the session. It was needed to develop an extra App in order to do so but that is a private app.

Uploading Screen Recording 2024-05-17 at 23.22.38.mov…

vtex-io-ci-cd[bot] commented 5 months ago

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

vtex-io-docs-bot[bot] commented 5 months ago

Beep boop :robot:

I noticed you didn't make any changes at the docs/ folder

In order to keep track, I'll create an issue if you decide now is not a good time

beatrizmaselli commented 5 months ago

This is not needed so I am closing this PR