vtex-apps / store-link

The Store Link app provides blocks for displaying links in other theme blocks
4 stars 5 forks source link

Fixed key in regex to remove special characters #24

Closed anto90fg closed 3 years ago

anto90fg commented 3 years ago

What problem is this solving?

The regex in the InterpolateLink.ts file threw an error when it encountered special characters. Solution, created a new key by removing the special characters in the previous one.

How to test it?

Create a specification attribute that includes "+++-50%" and try to take the value of any other specification with link.product, with the previous version an error is triggered, in the current one the value is taken correctly. Ws with previous version: https://sendtomiguel--itwhirlpoolqa.myvtex.com/Prodotti/Lavaggio-e-Asciugatura/Lavatrici Ws with fixed version: https://pullregex--itwhirlpoolqa.myvtex.com/Prodotti/Lavaggio-e-Asciugatura/Lavatrici

The link.product is the one highlighted in the image. image

vtex-io-ci-cd[bot] commented 3 years ago

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

vtex-io-docs-bot[bot] commented 3 years ago

Beep boop :robot:

I noticed you didn't make any changes at the docs/ folder

In order to keep track, I'll create an issue if you decide now is not a good time

anto90fg commented 3 years ago

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • [X] There's nothing new to document 🤔
  • [ ] I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • [ ] I just updated 🎉🎉

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • [X] Patch (backwards-compatible bug fixes)
  • [ ] Minor (backwards-compatible functionality)
  • [ ] Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • [ ] No thanks, I would rather do it manually 😞
anto90fg commented 3 years ago

As suggested by @igorbrasileiro I have included an optional parameter for the regexp so that the user can choose whether or not to use it or what to use. I've updated the app on the workspace https://pullregex--itwhirlpoolqa.myvtex.com, and you can test it working properly on the search page https://pullregex--itwhirlpoolqa.myvtex.com/Prodotti/Lavaggio-e-Asciugatura/Lavatrici. @igorbrasileiro @victorhmp

anto90fg commented 3 years ago

I lint all the pages and made the requested changes

vtex-io-ci-cd[bot] commented 3 years ago

Your PR has been merged! App is being published. :rocket: Version 0.7.2 → 0.7.3

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.store-link@0.7.3

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. :book:

igorbrasileiro commented 3 years ago

@allcontributors @anto90fg

allcontributors[bot] commented 3 years ago

@igorbrasileiro

I could not determine your intention.

Basic usage: @all-contributors please add @someone for code, doc and infra

For other usages see the documentation

igorbrasileiro commented 3 years ago

@all-contributors please add @anto90fg for code

allcontributors[bot] commented 3 years ago

@igorbrasileiro

I've put up a pull request to add @anto90fg! :tada: