search

vtex / faststore

Digital commerce toolkit for frontend developers
https://faststore.dev
MIT License
186 stars 58 forks source link

[patch] fix: `Carousel` icon color cascade #2297

Closed renatamottam closed 4 months ago

renatamottam commented 4 months ago

What's the purpose of this pull request?

The Carousel Icons styles where affecting other unrelated icons inside the ProductCard, so I fixed the specificity of the code.

How it works?

Before After
image image

How to test it?

  1. Change line 120 on packages/core/src/components/product/ProductCard/ProductCard.tsx to onButtonClick={() => {}}
  2. Run yarn dev
  3. Go to homepage and hover a Carousel
vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **faststore-site** | ⬜️ Ignored ([Inspect](https://vercel.com/faststore/faststore-site/AS9FeSA9WEWcJv8CBkpBGUohL4m7)) | [Visit Preview](https://faststore-site-git-fix-carousel-styles-faststore.vercel.app) | | May 2, 2024 6:18pm |
codesandbox-ci[bot] commented 4 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.