search

vtex / faststore

Digital commerce toolkit for frontend developers
https://faststore.dev
MIT License
186 stars 58 forks source link

Feat: Next 13 Root Layout #2300

Closed eduardoformiga closed 4 months ago

eduardoformiga commented 4 months ago

Depends on

What's the purpose of this pull request?

This PR aims to create the root layout.tsx and bring the components from the src folder to the app folder.

Most of the changes from this PR are related to the path change to the app folder. But there are also new 'use clients' added to some components.

The sections should be implemented/moved in other PR's related to another JIRA task.

How to test it?

Make sure that the older pages are working as expected and also the http://localhost:3000/fs-next-update is rendering (blank) without errors.

Starter PR

TBD

References

https://nextjs.org/docs/app/api-reference/file-conventions/layout

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **faststore-site** | ⬜️ Ignored ([Inspect](https://vercel.com/faststore/faststore-site/4w19otw3shaaxVsZbCqgfnF8rdSs)) | [Visit Preview](https://faststore-site-git-feat-next-13-global-section-4ef07d-faststore.vercel.app) | | May 7, 2024 6:53pm |
codesandbox-ci[bot] commented 4 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

eduardoformiga commented 4 months ago

question: I thought we were going to put the app directory inside /src, why not put it inside? Will we change it after fully migrating?

We can put as this doc explains. But at this time, I think it would be safer to keep far from the older code just to give us a better perception of the changes, as we will probably need to keep some duplicated files to mantain retro compatibility with older APIs.