Closed lucasfp13 closed 4 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
faststore-site | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 16, 2024 5:00pm |
@lucasfp13 can you pls check the error why codesandbox
build is failing? It would be great if we could test in the starter too.
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
hey, @lucasfp13 does descriptionData
support a TSX component, in the Title and Content array?
const override: SectionOverride = {
section: SECTION,
components: {
__experimentalProductDescription: {
props: { descriptionData: [{ title: 'Title', content: 'Some content' }] },
},
},
}
hey, @lucasfp13 does
descriptionData
support a TSX component, in the Title and Content array?const override: SectionOverride = { section: SECTION, components: { __experimentalProductDescription: { props: { descriptionData: [{ title: 'Title', content: 'Some content' }] }, }, }, }
@victors1682 as of right now, the answer appears to be no.
What's the purpose of this pull request?
This PR intends to enable override for
ProductDescription
component and props inProductDetails
section.How it works?
You can override
ProductDescription
using__experimentalProductDescription
.How to test it?
In the
@faststore/core
package:In
packages/core/src/customizations/src/components/overrides/ProductDetails.tsx
change the following code:
In the
starter.store
:Starters Deploy Preview
https://github.com/vtex-sites/starter.store/pull/446
Using the changes of the PR above, you can test by running the store locally (
yarn dev
) then go tohttp://localhost:3000/api/preview?contentType=pdp&documentId=4675d165-170d-11ef-8452-12a5e84da56d&versionId=eb329256-7113-4f74-9087-6e0838e77aaa
, that's the version using the draft changes I made.