search

vtex / faststore

Digital commerce toolkit for frontend developers
https://faststore.dev
MIT License
182 stars 57 forks source link

fix: `Module not found` build warning #2338

Closed lucasfp13 closed 1 month ago

lucasfp13 commented 1 month ago

What's the purpose of this pull request?

This PR intends to fix the Module not found: Can't resolve 'encoding' build warning.

How it works?

Everything should work as before.

Starters Deploy Preview

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
faststore-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 10:58pm
codesandbox-ci[bot] commented 1 month ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci[bot] commented 1 month ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

lucasfp13 commented 1 month ago

After initial investigation, probably this warning is being thrown because of the external lib @vtex/client-cms, we should validate with the responsible team if it's valid to upgrade this dependency there.