vtex / faststore

Digital commerce toolkit for frontend developers
https://faststore.dev
MIT License
189 stars 60 forks source link

fix: copy public folder back to root dir (fix vercel build) #2351

Closed eduardoformiga closed 3 months ago

eduardoformiga commented 3 months ago

What's the purpose of this pull request?

When we use the public folder in the root from the starter, maybe to add a new favicon, the build from projects from FSW does not load other files, like the icons.svg. This PR aims to copy back the public folder from .faststore/public to the public folder from the root directory after the build command so that the build can leverage all files over there.

How to test it?

see the starter PR

Please take a look at the different favicon and also the icons that are being loaded.

The previous preview without the changes from this PR with the favicon but without the icons: https://starter-1sjtb4i7u-faststore.vercel.app/

with favicon + Without icons / with favicon + with icons

Screenshot 2024-06-17 at 19 29 08

Starters Deploy Preview

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
faststore-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2024 10:15pm
codesandbox-ci[bot] commented 3 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.