search

vtex / faststore

Digital commerce toolkit for frontend developers
https://faststore.dev
MIT License
182 stars 57 forks source link

feat: Change order of sku selector #2374

Closed lucvysk closed 1 week ago

lucvysk commented 3 weeks ago

What's the purpose of this pull request?

Makes the sku selector follow the order of the admin

How it works?

Same adjust was done while ago to IO! The code needs to validates if it's number prior sorting this. For example, if you sort a - b for sizes, you will have different orders, mostly thinking in cross language.

e.g, sorting sizes in PT:

G - M - P

Commit in IO: https://github.com/vtex-apps/store-components/blob/2fe597cf00b0d2968487189f99ccaf80b73e5da6/react/components/SKUSelector/components/SKUSelector.tsx#L247

How to test it?

This product: admin / IO / stable / fast.

image

image

image

image

After fix:

image

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
faststore-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2024 6:45pm
codesandbox-ci[bot] commented 3 weeks ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.