fix: has child items logic on validate cart (bug)

vtex / faststore

Digital commerce toolkit for frontend developers

https://faststore.dev

MIT License

191 stars 61 forks source link

fix: has child items logic on validate cart (bug) #2524

Closed EmanuelRamos115 closed 3 weeks ago

EmanuelRamos115 commented 4 weeks ago

What's the purpose of this pull request?

Solves the bug when I have the same item with attachment without necessarily having the same number of attachments

How it works?

The validation done previously was always returning false, now it returns correctly

How to test it?

Add products with assembly, but do not add the same total amount of assembly

Checklist

PR Title and Commit Messages

[x] PR title and commit messages follow the Conventional Commits specification
- Available prefixes: feat, fix, chore, docs, style, refactor and test

PR Description

[x] Added a label according to the PR goal - breaking change, bug, contributing, performance, documentation..

Dependencies

[x] Committed the yarn.lock file when there were changes to the packages

vercel[bot] commented 4 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
faststore-site	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 24, 2024 4:23pm

codesandbox-ci[bot] commented 4 weeks ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

hellofanny commented 3 weeks ago

Hey @EmanuelRamos115 👋 Could you help me test this behavior? Would you mind sharing a link preview of a store where I can check it out? Thank you!

EmanuelRamos115 commented 3 weeks ago

Hey @EmanuelRamos115 👋 Could you help me test this behavior? Would you mind sharing a link preview of a store where I can check it out? Thank you!

Of Course! Here -> https://sfj-cb44a59--jwpepperdev.preview.vtex.app/1309475-4630/p

hellofanny commented 3 weeks ago

hey @EmanuelRamos115 the code looks fine, but we were trying to reproduce the reported scenario of adding products with assembly options and we're getting a different error when trying to add to cart. Is this preview link updated?