vtex / faststore

Digital commerce toolkit for frontend developers
https://faststore.dev
MIT License
191 stars 61 forks source link

Chore: Fix CLS issues and Navbar dynamic imports #2526

Closed hellofanny closed 3 weeks ago

hellofanny commented 1 month ago

What's the purpose of this pull request?

Mobile Desktop
CLS-Mobile CLS-Desk

How it works?

Starter CLS fixes + navbar improvements
mob-starter mob-perf
Starter CLS fixes + navbar improvements
desk-starter desk-perf

How to test it?

Use this preview link for tests: https://sfj-1842eea--starter.preview.vtex.app

  1. Everything should be working as before
  2. Check if the layout shift in the RegionBar is still happening
  3. Try testing the link in https://pagespeed.web.dev/

Starters Deploy Preview

https://github.com/vtex-sites/starter.store/pull/587

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **faststore-site** | ⬜️ Ignored ([Inspect](https://vercel.com/faststore/faststore-site/14sgUQ8p3cpueXD91xRcF3Z7NQNC)) | [Visit Preview](https://faststore-site-git-chore-fix-cls-issues-navbar-e55b35-faststore.vercel.app) | | Oct 24, 2024 11:47pm |
codesandbox-ci[bot] commented 1 month ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.