vtex / faststore

Digital commerce toolkit for frontend developers
https://faststore.dev
MIT License
191 stars 61 forks source link

Feat: Applies next/dynamic for SearchInput & adjustments #2550

Closed hellofanny closed 1 week ago

hellofanny commented 2 weeks ago

What's the purpose of this pull request?

note: I'm not using dynamic import for UISearchInput because the searchRef is used in the useOnClickOutside. If the component isn’t rendered yet and we click on the screen, the ref isn’t available, which could cause an error. To avoid changing the code and introducing this issue, I've chosen not to use dynamic import here. Any other opinion here?

How to test it?

Test using the preview or running local

testing on mobile screen size (Moto G Power):

image image

testing on desktop:

image

Starters Deploy Preview

https://github.com/vtex-sites/starter.store/pull/606

Reference

POC

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
faststore-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 6:58pm
codesandbox-ci[bot] commented 2 weeks ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.