vtex / faststore

Digital commerce toolkit for frontend developers
https://faststore.dev
MIT License
191 stars 61 forks source link

feat: split the global sections in own file #2554

Closed eduardoformiga closed 6 days ago

eduardoformiga commented 1 week ago

What's the purpose of this pull request?

This PR is part of the performance initiative and aims to split the global sections into its own file.

Let's initially separate the components of each page type into their own files; this will help organize the import of components by page type (in other tasks) and opens up the possibility of only importing customized components based on the page type in the future, instead of all components, as we currently do.

The idea is to stop using the GlobalSections component in the tree of each page, but since we are not doing this for all pages yet, we’ll keep it temporarily. We will only remove the use of this component on the homepage (in another task). Once we’ve done this for all pages, we can remove this component entirely, but we will keep the function getGlobalSectionsData. (packages/core/src/components/cms/GlobalSections.tsx). Global sections will now be imported into the sections file of each page and passed directly to RenderSections.

Starters Deploy Preview

Preview https://sfj-923b60d--starter.preview.vtex.app/

References

POC PR

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **faststore-site** | ⬜️ Ignored ([Inspect](https://vercel.com/faststore/faststore-site/84EuaQvjXxvReoAXZH6UrKzAcgoG)) | [Visit Preview](https://faststore-site-git-feat-sfs-1510-split-global-4aebfe-faststore.vercel.app) | | Nov 19, 2024 3:10pm |
codesandbox-ci[bot] commented 1 week ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.