Chore/bump prom client - Githubissues

vtex / node-vtex-api

VTEX IO API Client for Node

76 stars 16 forks source link

Chore/bump prom client #531

Closed filafb closed 1 year ago

filafb commented 1 year ago

What is the purpose of this pull request?

This version bumps the prom-client version to remove a deprecation warning in the CLI when linking a project to the node builder using node 16.

What problem is this solving?

It removes the following deprecation warning from CLI when linking an application. Screenshot 2023-07-03 at 4 12 48 PM

How should this be manually tested?

Create a new workspace in vtexgame1 account;
Run yarn link in the node-vtex-api;
Open a project using the node builder and update the version to 7.x;
In the same project, cd to /node and run yarn link @vtex/api;
Link the project to the workspace. You should not see the warning above.

Types of changes

[X] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Requires change to documentation, which has been updated accordingly.