search

vtex / shoreline

Design System for the VTEX Admin that replaces "Admin UI" and "Styleguide"
https://shoreline.vtex.com
15 stars 0 forks source link

feat(page): replace slot by page-header-row #1587

Closed matheusps closed 2 months ago

matheusps commented 2 months ago

Summary

Slot is hard to understand and document. This PR creates the PageHeaderRow component to replace it on the PageHeader context. The main goal here is to enhance the design system semantics and cohesion, lowering the learning curve.

We should also remove Slot from other components as well.

🚨 This is a breaking change that affects all users using the PageHeader

Examples

Before

<Page>
  <PageHeader>
    <Slot name="top">{/* ... */}</Slot>
    <Slot name="bottom">{*/ ... */}</Slot>
  </PageHeader>
</Page>

After

<Page>
  <PageHeader>
    <PageHeaderRow>{/* ... */}</PageHeaderRow>
    <PageHeaderRow>{*/ ... */}</PageHeaderRow>
  </PageHeader>
</Page>
vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Updated (UTC) | | :--- | :----- | :------ | :------ | | **shoreline-docs** | ⬜️ Ignored ([Inspect](https://vercel.com/vtex/shoreline-docs/AC7FU7Yn44ozwzjxXQHxXrhhLnhp)) | | Apr 24, 2024 2:10pm |