Replace Slot by contextual components - Githubissues

vtex / shoreline

Design System for the VTEX Admin that replaces "Admin UI" and "Styleguide"

https://shoreline.vtex.com

15 stars 0 forks source link

Replace Slot by contextual components #1588

Closed matheusps closed 2 months ago

matheusps commented 2 months ago

Problem

The Slot concept is hard to understand, work with, and document.

Inconsistent: Can be used with or without name.

<ModalHeader>
  <Slot>{/* ... */}</Slot>
</ModalHeader>

<Page>
  <PageHeader>
    <Slot name="top">{/* ... */}</Slot>
    <Slot name="bottom">{*/ ... */}</Slot>
  </PageHeader>
</Page>

Weak typing: If we type name as "top" | "bottom" | etc it will not be clear where to use them

Solution

The impacted components are:

[x] PageHeader
[x] Collection
[x] CollectionView
[x] EmptyState
[x] Field
[x] Input
[x] Modal

Usage examples

No response

Dependencies

No response

References

No response

matheusps commented 2 months ago

Implementation on PageHeader : #1587