search

vtex / shoreline

Design System for the VTEX Admin that replaces "Admin UI" and "Styleguide"
https://shoreline.vtex.com
15 stars 0 forks source link

feat(select): unify select approaches #1594

Closed matheusps closed 2 months ago

matheusps commented 2 months ago

Summary

Currently we have two types of selects: Native and Custom. This PR unifies the approaches, using only a custom select. It was implemented using Ariakit. So this PR:

  1. Removes the Select from Primitives
  2. Add the Primitive/Select components into Components/Select
  3. Create a custom select theming
  4. Migrate filter to use the new select.

Examples

Before

<Select>
  <option value="option 1">option 1</option>
  <option value="option 2">option 2</option>
  <option value="option n">option n</option>
</Select>

After

<Select>
  <SelectItem value="option 1">option 1</SelectItem>
  <SelectItem value="option 2">option 2</SelectItem>
  <SelectItem value="option n">option n</SelectItem>
</Select>
vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **shoreline-docs** | ⬜️ Ignored ([Inspect](https://vercel.com/vtex/shoreline-docs/6rVGTcCoJczWEbtBidapMLT81juD)) | [Visit Preview](https://shoreline-docs-git-feature-unify-select-vtex.vercel.app) | | Apr 30, 2024 6:01pm |