docs(innersource): add open a pull request documentation

vtex / shoreline

Design System for the VTEX Admin, previously called Admin UI

https://shoreline.vtex.com

15 stars 0 forks source link

docs(innersource): add open a pull request documentation #1619

Closed lucasaarcoverde closed 1 month ago

lucasaarcoverde commented 1 month ago

Summary

Add how to open a pull request guide

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
shoreline-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 21, 2024 1:19pm

lucasaarcoverde commented 1 month ago

LGTM but I'm missing this information, which is crucial when contributing to forks: how to rebase? how to reconcile changes from the upstream branch to my own fork? Assuming that note everyone will be able to clone the repository, but will have to fork it instead.

I see this information being more relevant on open source, since we are working on innersource I've assumed that everyone will be able to clone the repo. I agree that is missing a how to rebase step, I'll add to the doc