search

vtex / shoreline

VTEX Design System for back-office experiences. Currently available for internal usage at VTEX.
https://shoreline.vtex.com
24 stars 1 forks source link

Search placeholder is not localizated #1705

Closed lafray closed 2 months ago

lafray commented 3 months ago

Who can be see in this code line the placehoder "Search" in the Search component is fixed and do not changes according to the language.

lucasaarcoverde commented 2 months ago

If I'm not mistaken, the idea is that the translation should be responsibility from the application. Is that right @beatrizmilhomem @davicostalf? Or should we have a default translated placeholder?

lafray commented 2 months ago

If I'm not mistaken, the idea is that the translation should be responsibility from the application. Is that right @beatrizmilhomem @davicostalf? Or should we have a default translated placeholder?

My big point is that other shoreline components take care of translating your text. I think this difference can generate misuse, where people don't realize that it is not translated

lucasaarcoverde commented 2 months ago

that's true @lafray, I agree with you on that! IMO we should remove the default label or add the translation. @beatrizmilhomem @davicostalf what's the best approach from the design perspective?

davicostalf commented 2 months ago

The requirement for this component is that there should be a default placeholder that is localized ("Search") and it should be possible to pass a customized message ("Search by name or ID").

beatrizmilhomem commented 2 months ago

This looks ready to be moved to the Backlog.

Summary

Fix the Search component placeholder.