search

vtex / shoreline

VTEX Design System for back-office experiences. Currently available for internal usage at VTEX.
https://shoreline.vtex.com
23 stars 1 forks source link

Pagination: Figma component props don't support single page scenario #1767

Closed davicostalf closed 1 week ago

davicostalf commented 1 month ago

Problem

A range needs to be specified

Captura de Tela 2024-07-29 às 17 22 25

Expected behavior

There should be a variant for this, layers shouldn't need to be manually hidden.

renatamottam commented 1 month ago

Agreed! Would also be nice to change next and previous variants to a toogle (using true/false as value).

davicostalf commented 1 month ago

I though about this as well, @renatamottam. I was unsure about this change since we plan boolean props so they are inactive by default, and in this scenario this would make the props strange. Something like previous and disableNext. But in this case I think it's worth it to open an exception.

beatrizmilhomem commented 1 month ago

Why do you think that showing 1 – 3 of 3 doesn't work?

davicostalf commented 1 month ago

It seems unnecessary to me. And I don't think the complexity added to the component is a problem, since it's a very simple component.

beatrizmilhomem commented 2 weeks ago

Next step: make the fix proposal.

davicostalf commented 1 week ago

Fixed in the last update to the Figma library.