Allow float gauges - Githubissues

vthiery / cpp-statsd-client

A header-only StatsD client implemented in C++

MIT License

51 stars 19 forks source link

Allow float gauges #39

Closed messiaen closed 3 years ago

messiaen commented 3 years ago

@vthiery Currently only int values can be given for gauges due to the functions definitions. I'd like to be able to send floats.

vthiery commented 3 years ago

the code looks good to me but i defer to @vthiery. also we need to allow CI to run too just to make sure

Thanks for the review @kevinkreiser ! I allowed the CI to run :+1:

messiaen commented 3 years ago

Thanks @vthiery and @kevinkreiser!

Fixed formatting
Added note about gaugePrecision in code examples in README
tweaked test.

dmitrifried commented 3 years ago

Hi @vthiery, are you planning on making a new release version with this commit? Right now our cmake dependency will have to point to the commit hash to get the float guages.

vthiery commented 3 years ago

Hi @vthiery, are you planning on making a new release version with this commit? Right now our cmake dependency will have to point to the commit hash to get the float guages.

Hi @dmitrifried I'll release a v2 today or tomorrow. I just need to prepare a quick migration guide since we've been making quite a lot of changes lately.

vthiery commented 3 years ago

Hi @vthiery, are you planning on making a new release version with this commit? Right now our cmake dependency will have to point to the commit hash to get the float guages.

Hi @dmitrifried I'll release a v2 today or tomorrow. I just need to prepare a quick migration guide since we've been making quite a lot of changes lately.

@dmitrifried I just released v2.0.0

dmitrifried commented 3 years ago

@vthiery Thanks for the quick work!