search

vthiery / cpp-statsd-client

A header-only StatsD client implemented in C++
MIT License
51 stars 19 forks source link

Add `-Wsign-conversion -Wsign-promo` compiler flags #43

Closed dsze closed 2 years ago

dsze commented 2 years ago

I'm trying to use cpp-statsd-client in a different project that uses stricter compiler warning flags on Linux. The changes in this PR were required to fix the issues found by the flags.

kevinkreiser commented 2 years ago

These flags are quite strict but your changes look correct to me and wider compatibility of the project with more downstream projects is a good thing!

Looks like the windows build is broken through no fault of your own. We will have to see if they changed the version available in CI

kevinkreiser commented 2 years ago

@dsze many thanks for updating to the later version of vs for the windows builds looks like everything is passing!