Chrome Dev updated WebSockets to version 13

vti / protocol-websocket

Protocol::WebSocket

Other

40 stars 27 forks source link

Chrome Dev updated WebSockets to version 13 #8

Closed leedo closed 13 years ago

leedo commented 13 years ago

I've been having some issues with WebSockets in the latest Chrome Dev release. I'm not 100% sure if this module is the cause yet, but I think it probably needs to be updated anyways.

http://updates.html5rocks.com/2011/10/WebSockets-updated-to-latest-version-in-Chrome-Canary

Looks like the relevant changes are:

Change the origin header name: Sec-WebSocket-Origin -> Origin
Sec-WebSocket-Version header value: 8 -> 13

leedo commented 13 years ago

d5c055d0c033624b93e1ca7e7372ea8c7a7cbbe1 is a quick fix. I'm guessing a real fix will require some refactoring.

vti commented 13 years ago

Thanks. I will try to find some time to fix it correctly.

vti commented 13 years ago

Try latest commit.

leedo commented 13 years ago

This doesn't seem to fix things for my app. I'm going to dig in and see what specifically is wrong tonight. My request (according to Chrome inspector) looks like this:

GET ws://localhost:8080/wsstream?msgid=0&t=1319561234.221&tab=a1f88099ebb1d9937b725d3c120c8aa6 HTTP/1.1
Origin: http://localhost:8080
Connection: Upgrade
Host: localhost:8080
Sec-WebSocket-Key: p7yMZjqboJEFvxUVDKO0bw==
Upgrade: websocket
Sec-WebSocket-Version: 13

vti commented 13 years ago

It should be fixed now (see last commit)! Tried it myself with the latest Chrome unstable.

leedo commented 13 years ago

Nice, I was about to submit a pull req with the exact 2 changes (minus the test :P).

Thanks, seems to be working on my end.

vti commented 13 years ago

Great. Closing :)