vti / sockjs-perl

SockJS Perl Plack/PSGI implementation
Other
21 stars 4 forks source link

t/transport/jsonp-send.t and t/transport/xhr-send.t started to fail #12

Closed eserte closed 5 years ago

eserte commented 5 years ago

My smokers started to report test failures:

...
    #   Failed test at t/transport/jsonp-send.t line 85.
    #     Structures begin differing at:
    #          $got->[0] = '200'
    #     $expected->[0] = '500'
    # Looks like you failed 1 test of 1.

#   Failed test 'return error when broken JSON'
#   at t/transport/jsonp-send.t line 91.
# Looks like you failed 1 test of 7.
t/transport/jsonp-send.t ..... 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/7 subtests 
...

    #   Failed test at t/transport/xhr-send.t line 85.
    #     Structures begin differing at:
    #          $got->[0] = '204'
    #     $expected->[0] = '500'
    # Looks like you failed 1 test of 1.

#   Failed test 'return error when broken JSON'
#   at t/transport/xhr-send.t line 91.
# Looks like you failed 1 test of 6.
t/transport/xhr-send.t ....... 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/6 subtests 

I suspect that this is caused by JSON::XS 4.00

vti commented 5 years ago

Thanks for the heads up. Should be fixed in the next release.

eserte commented 5 years ago

0.08 looks OK.